Remove admin user group
#436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 18, 2023 17:40
With `fastapi-users` integration, `User.is_superuser` flag has been introduced to identify admin users. This eliminates requirement for creating any specific user group for admin users. Hence, discard method to setup `admin` user group from the script. Signed-off-by: Jeny Sadadia <[email protected]>
API endpoints have been reworked to use `User.is_superuser` flag to determine admin users and not using `admin` user group anymore. Hence, drop check for `admin` user group in PUT `/user` handler. Signed-off-by: Jeny Sadadia <[email protected]>
Closed
4 tasks
Admin users are no logner required to be added to `admin` user group. Update unit tests and e2e tests for user creation accordingly. Discard e2e test to create and get `admin` user group. Signed-off-by: Jeny Sadadia <[email protected]>
r-c-n
reviewed
Dec 20, 2023
r-c-n
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
fastapi-usersintegration,User.is_superuserflag has been introduced to identify admin users.This eliminates the requirement for creating any specific user group for admin users. Hence, discard the method to setup
adminuser group from the script.